Is shanraisshan/claude-code-best-practice safe?
- Python shell/command execution
- MCP server launches a host command
- Python filesystem read
What to do: Nothing here argues against installing it. Grant the capabilities it lists only if you expect the tool to need them.
shanraisshan/claude-code-best-practice is an MCP server analyzed by SkillTotal's deterministic static scanner. The scan found no malicious indicators, though 1 risky construct is reported for review. It can: filesystem read, filesystem write, mcp tools detected and shell execution — capabilities are what the code can do, not a verdict on intent. Risk score 10/100 (low).
repo
Automated static-analysis result. It can contain false positives and false negatives, and is not a claim about the intent of shanraisshan/claude-code-best-practice's authors. Report a false positive.
Behavioral traits
How this component maps to the CSA agentic threat model. Descriptive — it never affects the risk score.
Findings (6)
An MCP server entry launches a command on your host.
Why it matters: Trusting the manifest means running that binary — verify what it is and where it comes from.
Fix: Verify the launched command and its source before trusting this MCP server configuration.
The component can run operating-system commands or spawn processes.
subprocess.run(
["which", player[0]],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
check=True
)subprocess.Popen(
audio_player + [str(file_path)],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
start_new_session=True …subprocess.run(
["which", player[0]],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
check=True
)subprocess.Popen(
audio_player + [str(file_path)],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
start_new_session=True …Why it matters: Powerful and often legitimate — confirm the commands aren't built from untrusted input.
Fix: Confirm the command and its arguments are fully controlled and not derived from untrusted input; avoid shell=True.
The component ships agent or IDE configuration that executes a command without a separate step: a Claude Code / Gemini CLI / Cursor hook, or a VS Code task that runs when the folder opens. Opening the project in that tool runs it with the developer's privileges. (25 occurrence(s) shown as evidence).
"command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py","command": "python3 ${CLAUDE_PROJECT_DIR}/.claude/hooks/scripts/hooks.py",Fix: Read the command and anything it runs before opening this project in an agent or editor. A published package has no reason to ship project auto-run config.
The component reads files from disk.
with open(local_config_path, "r", encoding="utf-8") as config_file:
with open(default_config_path, "r", encoding="utf-8") as config_file:
with open(local_config_path, "r", encoding="utf-8") as config_file:
with open(default_config_path, "r", encoding="utf-8") as config_file:
with open(local_config_path, "r", encoding="utf-8") as f:
with open(default_config_path, "r", encoding="utf-8") as f:
Why it matters: Usually legitimate, but worth confirming it can't be steered into reading sensitive files.
Fix: Confirm which files are read and that paths cannot be influenced by untrusted input to reach sensitive locations.
The component writes or deletes files on disk.
with open(log_path, "a", encoding="utf-8") as log_file:
with open(log_path, "a", encoding="utf-8") as log_file:
Why it matters: Usually legitimate, but worth confirming the paths can't be controlled by untrusted input.
Fix: Confirm which files are written/deleted and that paths cannot be influenced by untrusted input.
An MCP tool surface (manifest or tool definitions) was found.
"mcpServers": {Why it matters: Just context — review which tools it offers and their permissions.
Fix: Review the declared MCP tools and their permissions.
How attackers abuse these capabilities
Interactive labs on the attack class behind the rules above. They show the technique, not anything found in shanraisshan/claude-code-best-practice.
Check your own component
Run the same evidence-backed scan on any MCP server, agent skill, or package.
Scan your own componentHow we determine this: deterministic static analysis (regex + AST), evidence-anchored, no code execution. Methodology →